Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated class command #305

Merged
merged 5 commits into from
Apr 8, 2024
Merged

chore: remove deprecated class command #305

merged 5 commits into from
Apr 8, 2024

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Apr 8, 2024 •
edited
Loading

The class will be deprecated in KubeBlocks v0.9, so remove the class command.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Apr 8, 2024
@ldming ldming requested a review from iziang April 8, 2024 00:59
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 42.86%. Comparing base (8cd5bbd) to head (2a1e99d).

Files Patch % Lines
pkg/cmd/cluster/operations.go 70.58% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   43.16%   42.86%   -0.31%     
==========================================
  Files         218      213       -5     
  Lines       29287    28863     -424     
==========================================
- Hits        12642    12372     -270     
+ Misses      15094    14972     -122     
+ Partials     1551     1519      -32
Flag Coverage Δ
unittests 42.86% <80.76%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming
Copy link
Collaborator Author

ldming commented Apr 8, 2024

/approve to test

@ldming ldming merged commit f2e2e7c into main Apr 8, 2024
12 checks passed
@ldming ldming deleted the support/remove-class-cmd branch April 8, 2024 03:45
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 8, 2024
@ldming
Copy link
Collaborator Author

ldming commented Apr 8, 2024

/cherry-pick release-0.9

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

🤖 says: Error cherry-picking.

Failed to merge submodule addons (not checked out)
CONFLICT (submodule): Merge conflict in addons
Auto-merging pkg/types/types.go
Recursive merging with submodules currently only supports trivial cases.
Please manually handle the merging of each conflicted submodule.
This can be accomplished with the following steps:

  • come back to superproject and run:

    git add addons

    to record the above merge or update

  • resolve any other conflicts in the superproject

  • commit the resulting index in the superproject
    error: could not apply f2e2e7c... chore: remove deprecated class command (chore: remove deprecated class command #305)
    hint: After resolving the conflicts, mark them with
    hint: "git add/rm ", then run
    hint: "git cherry-pick --continue".
    hint: You can instead skip this commit with "git cherry-pick --skip".
    hint: To abort and get back to the state before "git cherry-pick",
    hint: run "git cherry-pick --abort".

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/8595072619

@ldming
Copy link
Collaborator Author

ldming commented Apr 8, 2024

Picked to release-0.9 manually.

ldming added a commit that referenced this pull request Apr 8, 2024
@ldming
chore: remove deprecated class command (#305)
5da0197 
(cherry picked from commit f2e2e7c)
ldming added a commit that referenced this pull request Apr 8, 2024
@ldming
chore: remove deprecated class command (#305)
f068f7c 
(cherry picked from commit f2e2e7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iziang iziang iziang approved these changes

@wangyelei wangyelei wangyelei approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

@1aal 1aal Awaiting requested review from 1aal 1aal is a code owner

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
Release 0.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ldming @codecov-commenter @iziang @wangyelei @apecloud-bot